experiemntal: add StoreController to allowing extending interface #752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
*database.StoreController
type to allow us to extend goose behavior without breaking the coreStore
interface.We can document any optional methods by having a well-defined type like the
*database.StoreController
. It becomes much easier to reason about in the code than the type assertions and hidden interfaces. A good example of this in the wild is the ResponseController added to the net/http package in Go.For a practical example see #461. The request here was to support a more graceful operation for checking whether the version table exists or not.
I've gone ahead and implemented the Postgres-specific version of the
TableExists()
method. And the nice thing is we can incrementally update the rest of the dialect implementations piecemeal.But we always fallback to some less optimized version if
ErrNotSupported
is returned.