-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix docker example and include pyproject.toml #1121
Conversation
We could probably already do something like this: [tool.pixi.feature.prod.pypi-dependencies]
docker-project = { path = ".", editable = false } And remove the |
examples/docker/pyproject.toml
Outdated
default = ["test", "build", "dev"] | ||
prod = ["prod"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both envs need to be in the same solve-group, otherwise this example is a bit pointless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This posed a problem, so it was good we tested this. Made an issue for it here: #1123
@@ -1,16 +1,44 @@ | |||
[build-system] | |||
requires = ["hatchling"] | |||
build-backend = "hatchling.build" | |||
requires = ["flit_core>=3.2,<4"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning behind switching to flit?
Isn't flit old-school nowadays?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so I would rather use, hatch but currently because of PEP517 mismatch uv is currently not supporting the prepare_metadata_for_build_wheel
. See: astral-sh/uv#2130. I'd rather not use setuptools
cause it makes the .egg-info
in the source and because of legacy reasons. Do you know of another good build backend?
Or we go back the postinstall-production route and maybe wait until we find a better solution to the general problem as mentioned in #1088 (comment) |
Yeah, lets postpone that for now, I've reverted back to manual installation. Please check it out @pavelzw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fixes the docker example as pointed out by @pavelzw, will be a bit better when the #1092 is merged.
Also removes pixi.toml in favor for a single pyproject.toml