-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: codepath alerts #3645
GitHub: codepath alerts #3645
Conversation
const refreshToken = process.env.OAUTH2_REFRESH_TOKEN; | ||
|
||
// validate params | ||
if (!repo || !prNumber || !token || !clientId || !clientSecret | !refreshToken) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for using a bitwise OR operator (|
) for refreshToken
? It seems like a logical OR (||
) might be more appropriate for this comparison, as we're checking the presence of multiple variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
@oronno - you may have noticed this already, but just in case, IX is the first entry in the
|
Great. Thanks for implementing. |
@oronno - I opened a test PR. You guys should have received email. The github workflow notification indicates it worked... please confirm?
|
Confirmed it is working as expected. We received email in the mentioned address. |
🔧 Type of changes
✨ What's the context?
Allow adapters and module owners to register for alerts when a PR is opened against their code. See prebid/prebid-server#4075
I tested this over in the sourcecred repo and have set up the config file just for Index Exchange at this point. Working on Prebid documentation for it.