Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reviewer Checklist #3520

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Reviewer Checklist #3520

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fea59b9
Add Reviewer Checklist
AntoxaAntoxic Oct 21, 2024
db29809
Add Reviewer Checklist
AntoxaAntoxic Oct 21, 2024
f93760e
Add Zero Non Deal Bids Warning Only in Debug
AntoxaAntoxic Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ What's the context for the changes? Are there any
Why did you choose to make these changes? Were there any trade-offs you had to consider?


### 🔎 New Bid Adapter Checklist
- [ ] verify email contact works
- [ ] NO fully dynamic hosts
- [ ] geographic host parameters are NOT required
- [ ] NO direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job*
- [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - *define the new adapter as the alias of the generic adapter*
- [ ] cover an adapter configuration with an integration test


### 🧪 Test plan

How do you know the changes are safe to ship to production?
Expand Down
Loading