Tradplus #3508

tradplus · 2024-10-16T10:43:40Z

TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.

Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.

this is TradPlus adapter version 1.0.

Thank!

AntoxaAntoxic · 2024-10-16T11:39:03Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+
+    @Override
+    public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequest) {
+        final Map<ExtImpTradPlus, List<Imp>> extToImps = new HashMap<>();


using a map here is an overhead since only one single imp is really utilized to retrieve the ext object, please get rid of it

I have changed these codes，please review these codes.

AntoxaAntoxic · 2024-10-16T11:40:37Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+    private static List<Imp> removeFirstImpExt(List<Imp> imps) {
+        imps.set(0, imps.getFirst().toBuilder().ext(null).build());
+        return imps;
+    }


this looks redundant since the list of imps always has a single imp

I have changed these codes，please review these codes.

AntoxaAntoxic · 2024-10-16T11:41:18Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+    public Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequest bidRequest) {
+        try {
+            final BidResponse bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class);
+            return Result.of(extractBids(bidResponse, httpCall.getRequest().getPayload()), Collections.emptyList());


Result.withValues()

I have changed these codes，please review these codes.

AntoxaAntoxic · 2024-10-16T11:52:27Z

src/test/java/org/prebid/server/bidder/tradplus/TradPlusBidderTest.java

+import static org.prebid.server.proto.openrtb.ext.response.BidType.video;
+import static org.prebid.server.proto.openrtb.ext.response.BidType.xNative;
+
+public class TradPlusBidderTest extends VertxTest {


there is no any test that covers the outgoing http request:

payload: the basic logic of using only a single imp ignoring others

headers

impIds object

done, please review these codes.

AntoxaAntoxic · 2024-10-16T11:54:43Z

src/test/resources/org/prebid/server/it/test-application.properties

@@ -455,6 +455,8 @@ adapters.telaria.enabled=true
 adapters.telaria.endpoint=http://localhost:8090/telaria-exchange/
 adapters.theadx.enabled=true
 adapters.theadx.endpoint=http://localhost:8090/theadx-exchange
+adapters.tradplus.enabled=true
+adapters.tradplus.endpoint=http://localhost:8090/tradplus-exchange


please add the macros to the url to check them in the integration test

AntoxaAntoxic · 2024-10-24T11:12:27Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+    private ExtImpTradPlus parseImpExt(ObjectNode extNode) {
+        final ExtImpTradPlus extImpTradPlus;
+        try {
+            extImpTradPlus = mapper.mapper().convertValue(extNode, EXT_TYPE_REFERENCE).getBidder();


just return here

AntoxaAntoxic · 2024-10-24T11:13:15Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+        final MultiMap headers = HttpUtil.headers();
+        headers.set(HttpUtil.X_OPENRTB_VERSION_HEADER, X_OPENRTB_VERSION);
+        return headers;


return HttpUtil.headers().set(HttpUtil.X_OPENRTB_VERSION_HEADER, X_OPENRTB_VERSION);

AntoxaAntoxic · 2024-10-24T11:14:25Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+
+    @Override
+    public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequest) {
+        final List<HttpRequest<BidRequest>> httpRequests = new ArrayList<>();


I don't see the point to have the list if it's always only a single one

I have changed these codes，please review these codes.

AntoxaAntoxic · 2024-10-24T11:15:34Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+        try {
+            final ExtImpTradPlus extImpTradPlus = parseImpExt(bidRequest.getImp().getFirst().getExt());
+            validateImpExt(extImpTradPlus);
+            httpRequests.add(makeHttpRequest(extImpTradPlus, bidRequest.getImp(), bidRequest));


return the request here

AntoxaAntoxic · 2024-10-24T11:17:49Z

src/test/java/org/prebid/server/bidder/tradplus/TradPlusBidderTest.java

+                .satisfies(headers -> assertThat(headers.get(X_OPENRTB_VERSION_HEADER))
+                        .isEqualTo("2.5"));


please assert the default headers as well

AntoxaAntoxic · 2024-10-24T11:19:05Z

src/test/java/org/prebid/server/bidder/tradplus/TradPlusBidderTest.java

+        assertThat(result.getValue()).hasSize(1)
+                .extracting(HttpRequest::getPayload)
+                .extracting(BidRequest::getImp)
+                .extracting(List::size)
+                .containsOnly(2);


imp ext clean-up isn't covered

AntoxaAntoxic · 2024-10-24T11:20:11Z

src/test/java/org/prebid/server/bidder/tradplus/TradPlusBidderTest.java

+                BidRequest.builder()
+                        .imp(singletonList(Imp.builder().id("123").build()))
+                        .build(),
+                mapper.writeValueAsString(


please hide the mapper.writeValueAsString call inside the givenBidResponse

it's not done

why do you serialize twice?

AntoxaAntoxic · 2024-10-25T09:08:31Z

src/test/java/org/prebid/server/bidder/tradplus/TradPlusBidderTest.java

+
+        // then
+        assertThat(result.getErrors()).isEmpty();
+        assertThat(result.getValue())


assertThat(result.getValue()) .extracting(HttpRequest::getPayload) .flatExtracting(BidRequest::getImp) .extracting(Imp::getExt) .containsOnlyNulls();

AntoxaAntoxic · 2024-10-25T09:09:24Z

src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java

+    }
+
+    private static List<BidderBid> extractBids(BidResponse bidResponse, BidRequest bidRequest) {
+        return bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid()) ? Collections.emptyList() : bidsFromResponse(bidResponse, bidRequest.getImp());


I suspect this line fails checkstyle, please run it locally to check

Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:27:8: Unused import - java.util.ArrayList. [UnusedImports] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:56:37: Variable 'httpRequest' should be declared final. [FinalLocalVariable] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:79: Line is longer than 120 characters (found 123). [LineLength] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:80: Line is longer than 120 characters (found 135). [LineLength] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:106: Line is longer than 120 characters (found 167). [LineLength] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:110: Line is longer than 120 characters (found 243). [LineLength] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/tradplus/TradPlusBidder.java:125: Line is longer than 120 characters (found 134). [LineLength] Error: /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/bidder/tradplus/TradPlusBidderTest.java:324: Line is longer than 120 characters (found 131). [LineLength]

AntoxaAntoxic · 2024-10-25T13:55:34Z

The build is still red, please fix the checkstyle

also please do not forget about this comment as well

tradplus added 5 commits August 7, 2024 15:17

New Adapter: TradPlus

4f2b2dd

TradPlus: Update bidder

6ee24b5

Merge branch 'master' into tradplus

eed13bc

feat: change some code by reviewer commment

cef48a1

Merge branch 'prebid:master' into tradplus

77816f0

tradplus mentioned this pull request Oct 16, 2024

New Adapter: TradPlus #3361

Closed

Compile-Ninja requested a review from AntoxaAntoxic October 16, 2024 11:07

AntoxaAntoxic requested changes Oct 16, 2024

View reviewed changes

tradplus added 4 commits October 18, 2024 17:30

Merge branch 'prebid:master' into tradplus

5056de3

Merge branch 'prebid:master' into tradplus

1891f43

feat: change some code by reviewer commment

f926559

feat: change some code by reviewer comment

b1a4e7a

AntoxaAntoxic requested changes Oct 24, 2024

View reviewed changes

feat: change some code by reviewer comment

00f8cd0

AntoxaAntoxic requested changes Oct 25, 2024

View reviewed changes

feat: change some code by reviewer comment

77e4074

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tradplus #3508

Tradplus #3508

tradplus commented Oct 16, 2024

AntoxaAntoxic Oct 16, 2024

tradplus Oct 24, 2024

AntoxaAntoxic Oct 16, 2024

tradplus Oct 24, 2024

AntoxaAntoxic Oct 16, 2024

tradplus Oct 24, 2024

AntoxaAntoxic Oct 16, 2024

tradplus Oct 24, 2024

AntoxaAntoxic Oct 16, 2024

tradplus Oct 24, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 24, 2024

tradplus Oct 25, 2024

AntoxaAntoxic Oct 25, 2024 •

edited

Loading

AntoxaAntoxic Oct 25, 2024

AntoxaAntoxic Oct 25, 2024

AntoxaAntoxic Oct 25, 2024

AntoxaAntoxic commented Oct 25, 2024

		.satisfies(headers -> assertThat(headers.get(X_OPENRTB_VERSION_HEADER))
		.isEqualTo("2.5"));

Tradplus #3508

Are you sure you want to change the base?

Tradplus #3508

Conversation

tradplus commented Oct 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AntoxaAntoxic Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AntoxaAntoxic commented Oct 25, 2024

AntoxaAntoxic Oct 25, 2024 •

edited

Loading