-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon: bidonmultiformat updates #2503
Conversation
@@ -670,6 +693,12 @@ private RubiconImpExt makeImpExt(Imp imp, | |||
.build(); | |||
} | |||
|
|||
private Set<ImpMediaType> resolveFormats(ExtImpRubicon extImpRubicon, Set<ImpMediaType> impFormats) { | |||
return Optional.ofNullable(extImpRubicon.getFormats()) | |||
.or(() -> Optional.ofNullable(extImpRubicon.getParams()).map(ExtImpRubiconParams::getFormats)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.map
on new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for removed comment, missclick.
Do I get this change right, that multi format bid requests will trigger a bid request to magnite for every media type? |
Yes! |
No description provided.