GPP4: Functional tests for full GPP support
#2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule configuration
osulzhenko
added
work in progress
osulzhenko
changed the title
osulzhenko
changed the title
GPP4: Functional tests for full GPP support
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppFetchBidActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitPreciseGeoActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppFetchBidActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitPreciseGeoActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
osulzhenko
force-pushed
the
tests-gpp-full-support
branch
from
fb1f1a1
to
7bc66f5
Compare
osulzhenko
force-pushed
the
tests-gpp-full-support
branch
from
122282b
to
7d1981d
Compare
osulzhenko
force-pushed
the
tests-gpp-full-support
branch
from
2eb3c6d
to
939ce62
Compare
osulzhenko
force-pushed
the
tests-gpp-full-support
branch
from
939ce62
to
72fdacd
Compare
marki1an
reviewed
Jul 31, 2023
Comment on lines
15
to
20
| static AccountGppConfig getDefaultAccountGppConfig(PrivacyModule code, List<GppSectionId> skipSids = [], Boolean isEnabled = true) { | ||
| new AccountGppConfig().tap { | ||
| it.code = code | ||
| it.config = new SidsConfig().tap { it.skipSids = skipSids } | ||
| it.enabled = isEnabled | ||
| } |
There was a problem hiding this comment.
Do we need List<GppSectionId> skipSids = [] this one parameter and this it.config = new SidsConfig().tap { it.skipSids = skipSids }? Looks like redundat.
Comment on lines
613
to
618
| new UspNatV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_NAT_V1 | ||
| new UspCaV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_CA_V1 | ||
| new UspVaV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_VA_V1 | ||
| new UspCoV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_CO_V1 | ||
| new UspUtV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_UT_V1 | ||
| new UspCtV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_CT_V1 |
There was a problem hiding this comment.
Can be new UspNatV1Consent.Builder().build() because setMspaServiceProviderMode field don't effect at this spec, and check other cases
Comment on lines
592
to
596
| regsGpp << [ | ||
| "", | ||
| new UspNatV1Consent.Builder().build(), | ||
| new UspNatV1Consent.Builder().setGpc(false).build() | ||
| ] |
There was a problem hiding this comment.
Can be in 1 line, and check other cases
| def ampRequest = AmpRequest.defaultAmpRequest.tap { | ||
| it.account = accountId | ||
| it.gppSid = USP_NAT_V1.value | ||
| it.consentString = SIMPLE_GPC_DISALLOW_LOGIC |
There was a problem hiding this comment.
Same does not true for this spec, check other similar cases
marki1an
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.