-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPP4
: Functional tests for full GPP support
#2405
GPP4
: Functional tests for full GPP support
#2405
Conversation
…odule configuration
GPP4
: Functional tests for full GPP support
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppFetchBidActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitPreciseGeoActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppFetchBidActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitPreciseGeoActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
fb1f1a1
to
7bc66f5
Compare
122282b
to
7d1981d
Compare
2eb3c6d
to
939ce62
Compare
939ce62
to
72fdacd
Compare
static AccountGppConfig getDefaultAccountGppConfig(PrivacyModule code, List<GppSectionId> skipSids = [], Boolean isEnabled = true) { | ||
new AccountGppConfig().tap { | ||
it.code = code | ||
it.config = new SidsConfig().tap { it.skipSids = skipSids } | ||
it.enabled = isEnabled | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need List<GppSectionId> skipSids = []
this one parameter and this it.config = new SidsConfig().tap { it.skipSids = skipSids }
? Looks like redundat.
new UspNatV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_NAT_V1 | ||
new UspCaV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_CA_V1 | ||
new UspVaV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_VA_V1 | ||
new UspCoV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_CO_V1 | ||
new UspUtV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_UT_V1 | ||
new UspCtV1Consent.Builder().setMspaServiceProviderMode(1).build() | USP_CT_V1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be new UspNatV1Consent.Builder().build()
because setMspaServiceProviderMode
field don't effect at this spec, and check other cases
regsGpp << [ | ||
"", | ||
new UspNatV1Consent.Builder().build(), | ||
new UspNatV1Consent.Builder().setGpc(false).build() | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be in 1 line, and check other cases
def ampRequest = AmpRequest.defaultAmpRequest.tap { | ||
it.account = accountId | ||
it.gppSid = USP_NAT_V1.value | ||
it.consentString = SIMPLE_GPC_DISALLOW_LOGIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same does not true for this spec, check other similar cases
No description provided.