fix review11: refactos

prebid · Oct 24, 2024 · c0320b9 · c0320b9
1 parent bcb7d72
commit c0320b9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/...bid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInferenceDataService.java b/...bid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInferenceDataService.java
@@ -45,9 +45,7 @@ public List<ThrottlingMessage> extractThrottlingMessagesFromBidRequest(BidReques
                 .map(GreenbidsUserAgent::new)
                 .orElse(null);
 
-        return extractThrottlingMessages(
-                bidRequest,
-                userAgent);
+        return extractThrottlingMessages(bidRequest, userAgent);
     }
 
     private List<ThrottlingMessage> extractThrottlingMessages(

diff --git a/...prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationService.java b/...prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationService.java
@@ -115,7 +115,6 @@ private Ortb2ImpExtResult createOrtb2ImpExt(
         final Map<String, Boolean> impBiddersFilterMap = impsBiddersFilterMap.get(imp.getId());
         final ExplorationResult explorationResult = ExplorationResult.of(
                 greenbidsId, impBiddersFilterMap, isExploration);
-        return Ortb2ImpExtResult.of(
-                explorationResult, tid);
+        return Ortb2ImpExtResult.of(explorationResult, tid);
     }
 }
diff --git a/...ava/org/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsUserAgent.java b/...ava/org/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsUserAgent.java
@@ -42,19 +42,17 @@ public String getDevice() {
     public String getBrowser() {
         return Optional.ofNullable(userAgent)
                 .filter(userAgent -> !"Other".equals(userAgent.family) && StringUtils.isNoneBlank(userAgent.family))
-                .map(userAgent -> {
-                    final String major = Optional.ofNullable(userAgent.major).orElse(StringUtils.EMPTY);
-                    return "%s %s".formatted(userAgent.family, major).trim();
-                })
+                .map(ua -> "%s %s".formatted(ua.family, StringUtils.defaultString(userAgent.major)).trim())
                 .orElse(StringUtils.EMPTY);
     }
 
     private boolean isPC() {
+        final String osFamily = osFamily();
         return Optional.ofNullable(userAgentString)
                 .map(userAgent -> userAgent.contains("Windows NT")
-                        || PC_OS_FAMILIES.contains(osFamily())
-                        || ("Windows".equals(osFamily()) && "ME".equals(osMajor()))
-                        || ("Mac OS X".equals(osFamily()) && !userAgent.contains("Silk"))
+                        || PC_OS_FAMILIES.contains(osFamily)
+                        || ("Windows".equals(osFamily) && "ME".equals(osMajor()))
+                        || ("Mac OS X".equals(osFamily) && !userAgent.contains("Silk"))
                         || (userAgent.contains("Linux") && userAgent.contains("X11")))
                 .orElse(false);
     }

diff --git a/...n/java/org/prebid/server/hooks/modules/greenbids/real/time/data/core/OnnxModelRunner.java b/...n/java/org/prebid/server/hooks/modules/greenbids/real/time/data/core/OnnxModelRunner.java
@@ -18,7 +18,7 @@ public OnnxModelRunner(byte[] onnxModelBytes) throws OrtException {
     }
 
     public OrtSession.Result runModel(String[][] throttlingInferenceRow) throws OrtException {
-        final OnnxTensor inputTensor = OnnxTensor.createTensor(OrtEnvironment.getEnvironment(), throttlingInferenceRow);
+        final OnnxTensor inputTensor = OnnxTensor.createTensor(ENVIRONMENT, throttlingInferenceRow);
         return session.run(Collections.singletonMap("input", inputTensor));
     }
 }