Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github.com/rs/cors to v1.11.0 #177

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Jul 19, 2024

The update is to fix the dependabot issue triggered by the github.com/rs/cors version prior to v1.11.0. I wonder why the dependabot didn't pick it and didn't propose an autoupdate PR in this repository - do you know, by any chance?

Middleware causes a prohibitive amount of heap allocations when processing malicious preflight requests that include an Access-Control-Request-Headers (ACRH) header whose value contains many commas. This behavior can be abused by attackers to produce undue load on the middleware/server as an attempt to cause a denial of service.

References: rs/cors#145, rs/cors#173

@bsardo
Copy link
Collaborator

bsardo commented Sep 4, 2024

Hi @dmitris, I'm also not sure why dependabot did not open a PR for us. We do have dependabot alerts enabled and I do see a rule that it will ignore low priority vulnerabilities. I can't find where the priority is defined on this to determine whether that is the reason a PR was not opened.

Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guscarreon guscarreon merged commit 66940a7 into prebid:master Sep 6, 2024
3 checks passed
@dmitris dmitris deleted the upd-rs-cors branch September 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants