Nilablity Update w/ Rules #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Jul 26, 2023
| @@ -51,19 +51,19 @@ The `main` branch always contains latest code, so better use some package manage | |||
| - all enums, described in section 5, must be typed with section name singularized (e.g., "5.2 Banner Ad Types" -> `type BannerAdType int8`) | |||
| - all typed enums must have constants for each element, prefixed with type name (e.g., "5.2 Banner Ad Types - XHTML Text Ad (usually mobile)" -> `const BannerAdTypeXHTMLTextAd BannerAdType = 1`) | |||
| - never use `iota` for enum constants | |||
| - OpenRTB (2.x) section "5.1 Content Categories" should remain untyped and have no constants | |||
| - OpenRTB (2.x) "content categories" should remain untyped and have no constants | |||
There was a problem hiding this comment.
This section no longer exists but there are still several references to content categories.
| no | no | _required_ in spec | `Audio.MIMEs` | ||
| yes | yes | _required_ in spec, but is a part of mutually-exclusive group | `Imp.{Banner,Video,Audio,Native}` | ||
| no | yes | zero value (`""`, `0`) has no meaning, is defined in the spec as the default value, or represents time / duration | `Device.UA` | ||
| yes | yes | zero value (`""`, `0`) or value absence (`null`) has special meaning | `Device.{DNT,Lmt}` |
There was a problem hiding this comment.
Added our new rules for this nilability update and fixed casing of examples to match the object model.
AlexBVolcy
approved these changes
Aug 1, 2023
VeronikaSolovei9
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9 and other potential similar situations.