Michao Bid Adapter: Initial release #12507
Conversation
…g for parameter validation
|
Hi, regarding the proposed library, Muuki has provided support. |
|
This appears to add a lot of unhandled rejection messages to the circleci log Is it possible to make it less noisy? And if not, could it be more explicit in where the logs messages are coming from? Compare to master at: |
modules/michaoBidAdapter.js
Outdated
| } | ||
| } | ||
|
|
||
| const video = bid.mediaTypes?.video; |
There was a problem hiding this comment.
All these type checks are not appropriate in your adapter, the type check should have already happened somewhere else. If not, let's add it in that place so we don't have every adapter validating its input duplicatively
modules/michaoBidAdapter.js
Outdated
| } | ||
|
|
||
| if (params?.badv) { | ||
| if (!isArray(params?.badv)) { |
There was a problem hiding this comment.
This and the following two params you must also support from ortb.
| return []; | ||
| }, | ||
|
|
||
| onBidBillable: function (bid) { |
There was a problem hiding this comment.
Exciting to see this getting defined
modules/michaoBidAdapter.js
Outdated
| const bidRequest = context.bidRequests[0]; | ||
| const openRTBBidRequest = buildRequest(imps, bidderRequest, context); | ||
| openRTBBidRequest.cur = [ENV.DEFAULT_CURRENCY]; | ||
| openRTBBidRequest.test = config.getConfig('debug') ? 1 : 0; |
There was a problem hiding this comment.
This is a bit of a dangerous pattern, not all debug requests are test requests
modules/michaoBidAdapter.js
Outdated
| const openRTBBidRequest = buildRequest(imps, bidderRequest, context); | ||
| openRTBBidRequest.cur = [ENV.DEFAULT_CURRENCY]; | ||
| openRTBBidRequest.test = config.getConfig('debug') ? 1 : 0; | ||
| openRTBBidRequest.bcat = bidRequest.params?.bcat || []; |
There was a problem hiding this comment.
This might be defined on the ortb request object as well, am I reading correctly you only support it as a param?
| ); | ||
| } | ||
|
|
||
| return openRTBBidRequest; |
There was a problem hiding this comment.
Your doc says you only support site and user, but you seem to support device and other parts of ortb as well?
|
It is unclear why this build fails. What should I do? |
Just needed to be reran because it disconnected. |
|
@ChrisHuie |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
(Turn on debug mode)
Other information
Nice to meet you!
Thanks for the great solution.
We have developed a new adapter and noticed that the outstream video ad (in renderer) is not well maintained around it.
Prebid-outstream is not working in its current version and the examples on Prebid.org are not well maintained.
So we thought it would be useful to have a library dedicated to in-renderer integration without the need for hosting, so we developed one. (https://github.com/hogekai/in-renderer-js)
The UI has been adjusted for outstream video ads, and we plan to develop the README and other related documentation in the future.
(If you want to check how it works, you can check the test ads by using the debug mode and test parameters, as they are included in this adapter.)
If you would like, please let us know what you think and what steps you would like to take to get the in-renderer integration area in place.
(Perhaps this is not the right place to ask. If I'm wrong, please let me know where I should ask. I would appreciate it if you would consider that I am not as familiar with Prebid.js as the maintainer).