Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add support for forwarding viewport coordinates and fix deprecated scroll value (pageXOffset and pageYOffset) #12354

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vivekyadav15
Copy link

@vivekyadav15 vivekyadav15 commented Oct 22, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • FIX: Replace deprecated pageXOffset and pageYOffset with scrollX and scrollY respectively
  • ADD: Viewport coordinates in bidRequest.ext.vcoords

@patmmccann
Copy link
Collaborator

we're noticing some parallel implementations of this functionality; could you import from a library?

@vivekyadav15 vivekyadav15 marked this pull request as draft October 23, 2024 04:32
@vivekyadav15 vivekyadav15 changed the title Draft: Add support for forwarding viewport coordinate and fix deprecated scroll value (pageXOffset and pageYOffset) Draft: Add support for forwarding viewport coordinates and fix deprecated scroll value (pageXOffset and pageYOffset) Oct 23, 2024
…d scrollY respectively

- ADD: Viewport coordinate in bidRequest.ext.vcoords
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants