-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coinzilla Bid Adapter : add Web3 detection signal #12344
base: master
Are you sure you want to change the base?
Conversation
Tread carefully! This PR adds 11 linter errors (possibly disabled through directives):
|
@tiberiu-sevio looks like there are a few linting errors. Can you also please add unit tests? |
} | ||
if ((typeof window.tron !== 'undefined')) { | ||
installed_wallet = "TRX"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it appears this detection is very similar to
Prebid.js/modules/hypelabBidAdapter.js
Line 66 in 4b46054
eth: typeof window != 'undefined' && !!window.ethereum, |
Any chance you could move both detection routines into a utility in /libraries/crypto/index.js ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @patmmccann, we'd love to keep them at this moment as it is to see if there's traction with the web3 targeting.
Our ad codes are already up and running with this targeting on Coinzilla and that's why we'd love to have it available on our Prebid adapter as soon as possible too.
PS: Thank you @ChrisHuie for hinting the linter errors, we didn't changed any other logic, we just added the wallet detection, that's why we don't have unit testing on Prebid.
Our detection is already live at https://coinzillatag.com/lib/display.js
Cheers!
Type of change
Description of change
Added a web3 detection signal into the payload.