Coinzilla Bid Adapter : add Web3 detection signal #12344
Conversation
|
Tread carefully! This PR adds 11 linter errors (possibly disabled through directives):
|
|
@tiberiu-sevio looks like there are a few linting errors. Can you also please add unit tests? |
ChrisHuie
changed the title
| } | ||
| if ((typeof window.tron !== 'undefined')) { | ||
| installed_wallet = "TRX"; | ||
| } |
There was a problem hiding this comment.
Hi, it appears this detection is very similar to
Prebid.js/modules/hypelabBidAdapter.js
Line 66 in 4b46054
Any chance you could move both detection routines into a utility in /libraries/crypto/index.js ?
There was a problem hiding this comment.
Hello @patmmccann, we'd love to keep them at this moment as it is to see if there's traction with the web3 targeting.
Our ad codes are already up and running with this targeting on Coinzilla and that's why we'd love to have it available on our Prebid adapter as soon as possible too.
PS: Thank you @ChrisHuie for hinting the linter errors, we didn't changed any other logic, we just added the wallet detection, that's why we don't have unit testing on Prebid.
Our detection is already live at https://coinzillatag.com/lib/display.js
Cheers!
Type of change
Description of change
Added a web3 detection signal into the payload.