Price floors module : accept null floors

[mkomorski]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Other information

#10432

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/videobyteBidAdapter.js has 24 duplicated lines with modules/yieldliftBidAdapter.js
• modules/radsBidAdapter.js has 19 duplicated lines with libraries/dspxUtils/bidderUtils.js
• modules/radsBidAdapter.js has 26 duplicated lines with libraries/dspxUtils/bidderUtils.js
• modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 46 duplicated lines with modules/underdogmediaBidAdapter.js
• modules/gothamadsBidAdapter.js has 41 duplicated lines with modules/outbrainBidAdapter.js
• modules/gothamadsBidAdapter.js has 9 duplicated lines with modules/luponmediaBidAdapter.js
• modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js
• modules/colossussspBidAdapter.js has 11 duplicated lines with libraries/teqblazeUtils/bidderUtils.js
• modules/carodaBidAdapter.js has 17 duplicated lines with modules/dianomiBidAdapter.js
• modules/byDataAnalyticsAdapter.js has 8 duplicated lines with modules/kargoBidAdapter.js
• modules/appushBidAdapter.js has 18 duplicated lines with libraries/teqblazeUtils/bidderUtils.js
• modules/appushBidAdapter.js has 27 duplicated lines with libraries/teqblazeUtils/bidderUtils.js
• modules/adyoulikeBidAdapter.js has 45 duplicated lines with modules/retailspotBidAdapter.js
• modules/adtrgtmeBidAdapter.js has 36 duplicated lines with modules/yahooAdsBidAdapter.js
• modules/adfBidAdapter.js has 27 duplicated lines with modules/dianomiBidAdapter.js
• modules/33acrossBidAdapter.js has 79 duplicated lines with modules/onomagicBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/videobyteBidAdapter.js has 24 duplicated lines with modules/yieldliftBidAdapter.js
• modules/radsBidAdapter.js has 19 duplicated lines with libraries/dspxUtils/bidderUtils.js
• modules/radsBidAdapter.js has 26 duplicated lines with libraries/dspxUtils/bidderUtils.js
• modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
• modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
• modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js
• modules/marsmediaBidAdapter.js has 46 duplicated lines with modules/underdogmediaBidAdapter.js
• modules/gothamadsBidAdapter.js has 41 duplicated lines with modules/outbrainBidAdapter.js
• modules/gothamadsBidAdapter.js has 9 duplicated lines with modules/luponmediaBidAdapter.js
• modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js
• modules/colossussspBidAdapter.js has 11 duplicated lines with libraries/teqblazeUtils/bidderUtils.js
• modules/carodaBidAdapter.js has 17 duplicated lines with modules/dianomiBidAdapter.js
• modules/byDataAnalyticsAdapter.js has 8 duplicated lines with modules/kargoBidAdapter.js
• modules/appushBidAdapter.js has 18 duplicated lines with libraries/teqblazeUtils/bidderUtils.js
• modules/appushBidAdapter.js has 27 duplicated lines with libraries/teqblazeUtils/bidderUtils.js
• modules/adyoulikeBidAdapter.js has 45 duplicated lines with modules/retailspotBidAdapter.js
• modules/adtrgtmeBidAdapter.js has 36 duplicated lines with modules/yahooAdsBidAdapter.js
• modules/adfBidAdapter.js has 27 duplicated lines with modules/dianomiBidAdapter.js
• modules/33acrossBidAdapter.js has 79 duplicated lines with modules/onomagicBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀