PubMatic bid adapter add ortb2 device #11783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwrosewell I recommend you mark this as ready for review if you want Jason to take a look |
|
@pm-harshad-mane of note, this also picks up device.ip |
|
We are running QA check on this internally.... will provide the feedback in a week. |
pm-harshad-mane
changed the title
|
@jwrosewell our QA team has given a go ahead... can you please rebase the branch and merge the changes... |
pm-harshad-mane
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Looks good to me.
Thank you @jwrosewell for making the changes.
@jlquaccia tried to rebase thee repo but couldn't push the same.
Please rebase your branch and merge the PR if all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR enhances the Pubmatic bidder request by incorporating device data from the global ORTB2 object. Existing values in the Pubmatic device object will be overridden if they are also present in the global ORTB2 object. However, values unique to Pubmatic or not found in the global ORTB2 object will remain unchanged.
Motivation
The device object has previously been populated by simplistic parsers, if at all, and was inaccurate as a result. Prebid now benefits from RTD modules such as 51Degrees that enrich all the device object fields including Apple iPhone model category and device ID. The PR enables Pubmatic’s users to benefit from device object improvements.
Other information
cc: @PubMatic-OpenWrap @pm-azhar-mulla @pm-priyanka-deshmane @pm-nitin-shirsat