fix tests

prebid · Oct 23, 2024 · 56f316a · 56f316a
1 parent a187978
commit 56f316a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/modules/bidResponseFilter/index.js b/modules/bidResponseFilter/index.js
@@ -10,19 +10,23 @@ export const BID_ATTR_REJECTION_REASON = 'Attr is not allowed';
 let moduleConfig;
 let enabled = false;
 
-function init(addBidResponse = getHook('addBidResponse')) {
+function init() {
   config.getConfig(MODULE_NAME, (cfg) => {
     moduleConfig = cfg[MODULE_NAME];
     if (enabled && !moduleConfig) {
-      enabled = false;
-      addBidResponse.getHooks({hook: addBidResponseHook}).remove();
+      reset();
     } else if (!enabled && moduleConfig) {
       enabled = true;
-      addBidResponse.before(addBidResponseHook);
+      getHook('addBidResponse').before(addBidResponseHook);
     }
   })
 }
 
+export function reset() {
+  enabled = false;
+  getHook('addBidResponse').getHooks({hook: addBidResponseHook}).remove();
+}
+
 export function addBidResponseHook(next, adUnitCode, bid, reject, index = auctionManager.index) {
   const {bcat = [], badv = []} = index.getOrtb2(bid) || {};
   const battr = index.getBidRequest(bid)?.ortb2Imp[bid.mediaType]?.battr || index.getAdUnit(bid)?.ortb2Imp[bid.mediaType]?.battr || [];

diff --git a/test/spec/modules/bidResponseFilter_spec.js b/test/spec/modules/bidResponseFilter_spec.js
@@ -5,7 +5,7 @@ import {
   BID_CATEGORY_REJECTION_REASON,
   init,
   MODULE_NAME
-} from '../../../modules/bidResponseFilter';
+  , reset} from '../../../modules/bidResponseFilter';
 import {config} from '../../../src/config';
 import {addBidResponse} from '../../../src/auction.js';
 
@@ -21,6 +21,7 @@ describe('bidResponseFilter', () => {
   });
   afterEach(() => {
     config.resetConfig();
+    reset();
   })
 
   describe('enable/disable', () => {
@@ -32,9 +33,7 @@ describe('bidResponseFilter', () => {
     });
 
     it('should not run if not configured', () => {
-      config.setConfig({
-        bidResponseFilter: null
-      })
+      reset();
       addBidResponse.call({dispatch}, 'au', {}, reject);
       sinon.assert.notCalled(reject);
       sinon.assert.called(dispatch);