-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build on windows #555
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -89,6 +89,7 @@ | |||
"mocha": "^10.0.0", | |||
"prettier": "^2.7.1", | |||
"rimraf": "^3.0.2", | |||
"shx": "^0.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we just need mv
, I think we can find a simpler/smaller package for that.
I can't recall the name but I'm fairly certain there's a tiny (Windows-compatible) mv
CLI package, sorta like rimraf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I'm done with research, I found only this one.
I can write a script in JavaScript if you prefer it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move-cli
perhaps? I guess alternatively we could drop rimraf
for shx
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replaced rimraf with shx
. I think shx
is good for cross shell scripting, so it propbably will be needed if project require more sophisticated scripts
#554