Allow setting a signal value inside a computed #525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows setting a
signal
's value inside acomputed
. Previously the following code was not allowed and raised an error with the message "Computed cannot have side-effects":This suggested change is based on Slack discussions (TL;DR: there may be legitimate use-cases that the side-effect limitation blocks / the "regular" cycle detection might be enough for preventing runaway modification loops) and submitted here for further evaluation. /cc @developit @marvinhagemeister
This change saves some bytes from the output bundles: