refactor: implement signals-core with untranspiled classes #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the signals-core package to use ES6 classes instead of ES5-style prototypes. It effectively reverts the changes introduced in #160.
Notes:
declare
keyword. This avoids a redundant property assignment getting added to the class's constructor. There is a comment included that describes this reasoning.Computed
->Signal
toComputed
->Intermediate
->Signal
. The Preact binding needed to be modified to take this into account: settingSignal.prototype.constructor
toundefined
gets masked andComputed.prototype.constructor
is notundefined
anymore. Which led to this cursed piece of code by Yours Truly.The sizes of the build artifacts before and after this change are listed below. In general the number of bytes saved falls around 40-60 bytes, depending on the output format.