Fix: always reset the evaluation context upon entering an untracked block #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with multiple levels of mixed
effect
anduntracked
calls:The expected behavior is that the effect should not run when
s.value
is set to1
, becauses.value
was only used insideuntracked
. Therefore the effect should not become dependent ons.value
.The root cause is that only the outermost level of nested
untracked()
calls sets the evaluation context to undefined (which disables tracking). The fix is to unconditionally set the evaluation context to undefined inside everyuntracked
call. TheuntrackedDepth
counter then becomes unused.The first commit of this pull request adds a test for the issue. The second commit applies the fix and removes the
untrackedDepth
counter.The last commit does some minor refactoring: it just moves all tests related to
untracked
into their own section in the test file and modifies the test names accordingly. The last commit can be dropped if it feels superfluous.