build-image: Use 'OKD_VERSION' instead hard code version

[praveenkumar]

Summary by Sourcery

Build:

• Use the OKD_VERSION environment variable when creating a new OKD release.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request replaces the hardcoded OKD version with the 'OKD_VERSION' variable in the 'create_new_okd_release' function within the 'build-images.sh' script. This change ensures that the script uses the correct OKD version, which is defined as an environment variable.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Replaced hardcoded OKD version with the 'OKD_VERSION' variable.	Modified the 'create_new_okd_release' function to use the 'OKD_VERSION' variable instead of a hardcoded version.	okd-arm64/build-images.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @praveenkumar - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please add validation for the OKD_VERSION environment variable to ensure it's set and contains a valid version string.
• Consider adding documentation about the OKD_VERSION environment variable - where it should be set and what values are valid.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Consider adding validation for OKD_VERSION before usage

If OKD_VERSION is unset or empty, this could fail in unexpected ways. Consider adding a check like: [ -z "${OKD_VERSION}" ] && echo "Error: OKD_VERSION not set" && exit 1

Suggested change

	# Create a new release of okd using oc
	create_new_okd_release() {
	oc adm release new --from-release registry.ci.openshift.org/origin/release-scos:scos-4.18 \
	oc adm release new --from-release registry.ci.openshift.org/origin/release-scos:${OKD_VERSION} \
	# Create a new release of okd using oc
	create_new_okd_release() {
	if [ -z "${OKD_VERSION}" ]; then
	echo "Error: OKD_VERSION not set" >&2
	exit 1
	fi
	oc adm release new --from-release registry.ci.openshift.org/origin/release-scos:${OKD_VERSION} \