Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result Heading update #153

Closed
wants to merge 2 commits into from
Closed

Result Heading update #153

wants to merge 2 commits into from

Conversation

saiful64
Copy link

Related to #125

Describe the changes you've made

Adding exclamations Hurray if percentage is more than 50 or else Better luck next time in result page

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested out this on various outputs

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.

Screenshots (Images)

Before the changes After the Changes
<Upload_Screenshot> <Upload_Screenshot>

Recordings (Video with audio)

| Before the changes |
| cap2 |
| After the Changes |
| Capture
|

@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for arito ready!

Name Link
🔨 Latest commit c924ccd
🔍 Latest deploy log https://app.netlify.com/sites/arito/deploys/64a807dd3d2f14000844a43a
😎 Deploy Preview https://deploy-preview-153--arito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your First Pull Request! Wish you best on your open-source journey 😊

@saiful64
Copy link
Author

anything more needed to be done???

@saiful64 saiful64 closed this by deleting the head repository Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant