chore: move cache enabled label (kyverno#7949)

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
prady0t · Aug 1, 2023 · 9dd618c · 9dd618c
1 parent 9516f45
commit 9dd618c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/api/kyverno/constants.go b/api/kyverno/constants.go
@@ -4,6 +4,7 @@ const (
 	// Well known labels
 	LabelAppManagedBy     = "app.kubernetes.io/managed-by"
 	LabelAppComponent     = "app.kubernetes.io/component"
+	LabelCacheEnabled     = "cache.kyverno.io/enabled"
 	LabelCertManagedBy    = "cert.kyverno.io/managed-by"
 	LabelWebhookManagedBy = "webhook.kyverno.io/managed-by"
 	// Well known annotations

diff --git a/pkg/engine/context/resolvers/constants.go b/pkg/engine/context/resolvers/constants.go
diff --git a/pkg/engine/context/resolvers/resolvers_test.go b/pkg/engine/context/resolvers/resolvers_test.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/kyverno/kyverno/api/kyverno"
 	"github.com/kyverno/kyverno/pkg/engine/api"
 	"gotest.tools/assert"
 	corev1 "k8s.io/api/core/v1"
@@ -34,7 +35,7 @@ func createConfigMaps(ctx context.Context, client *kubefake.Clientset, addLabel
 		Data: map[string]string{"configmapkey": "key1"},
 	}
 	if addLabel {
-		cm.ObjectMeta.Labels = map[string]string{LabelCacheKey: "true"}
+		cm.ObjectMeta.Labels = map[string]string{kyverno.LabelCacheEnabled: "true"}
 	}
 	_, err := client.CoreV1().ConfigMaps(namespace).Create(
 		ctx, cm, metav1.CreateOptions{})

diff --git a/pkg/engine/context/resolvers/utils.go b/pkg/engine/context/resolvers/utils.go
@@ -4,6 +4,7 @@ import (
 	"errors"
 	"time"
 
+	"github.com/kyverno/kyverno/api/kyverno"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/selection"
@@ -13,7 +14,7 @@ import (
 
 func GetCacheSelector() (labels.Selector, error) {
 	selector := labels.Everything()
-	requirement, err := labels.NewRequirement(LabelCacheKey, selection.Exists, nil)
+	requirement, err := labels.NewRequirement(kyverno.LabelCacheEnabled, selection.Exists, nil)
 	if err != nil {
 		return nil, err
 	}

diff --git a/pkg/engine/context/resolvers/utils_test.go b/pkg/engine/context/resolvers/utils_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/kyverno/kyverno/api/kyverno"
 	"k8s.io/client-go/kubernetes"
 )
 
@@ -15,7 +16,7 @@ func TestGetCacheSelector(t *testing.T) {
 		wantErr bool
 	}{{
 		name: "ok",
-		want: LabelCacheKey,
+		want: kyverno.LabelCacheEnabled,
 	}}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {