Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jet Stirred Reactor (JSR) #126

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Jet Stirred Reactor (JSR) #126

wants to merge 22 commits into from

Commits on Feb 24, 2022

  1. Included species profile schema

    @anthonymstohr @sevyharris
    anthonymstohr authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    72d3d12 View commit details
    Browse the repository at this point in the history

  2. Added example JSR file as test case. Incomplete 

    Based on
https://github.com/comocheng/jsrcomparison/blob/master/Autoscience/new_zhang_jsr_phi0.25.yaml
which was updated after a telecon with Kyle and Bryan and Krishna and Richard and Nate.

Still has a few comments that need resolving
    @anthonymstohr @sevyharris
    anthonymstohr authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    50edfc0 View commit details
    Browse the repository at this point in the history

  3. Fixed test file errors and made schemas more compatiable with desired… 

    … format.
    @anthonymstohr @sevyharris
    anthonymstohr authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    1a51a63 View commit details
    Browse the repository at this point in the history

  4. Updated JSR test file after autoscience meeting

    @anthonymstohr @sevyharris
    anthonymstohr authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    956a7fc View commit details
    Browse the repository at this point in the history

  5. Fixed temperature JSR schema to match test file

    @anthonymstohr @sevyharris
    anthonymstohr authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    7c42f17 View commit details
    Browse the repository at this point in the history

  6. cleaned up anthony's test jsr yaml

    @sevyharris
    Sai Krishna authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    0d5a473 View commit details
    Browse the repository at this point in the history

  7. added a csv file for test jsr yaml

    @sevyharris
    Sai Krishna authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    6f55f8d View commit details
    Browse the repository at this point in the history

  8. Undo removing part of chemked_schema.yaml

    @sevyharris
    Krishna Sirumalla authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    6220857 View commit details
    Browse the repository at this point in the history

  9. Changed Datapoint to IgnitionDatapoint

    @sevyharris
    Sai Krishna authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    ced3ea8 View commit details
    Browse the repository at this point in the history

  10. deleted broken jsr schemas so pytests works

    @sevyharris
    Sai Krishna authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    4ff9c58 View commit details
    Browse the repository at this point in the history

  11. Move process_quantity method to superclass DataPoint 

    The idea is we can have multiple types of DataPoint
such as IgnitionDataPoint and JSRDataPoint
each will inherit from DataPoint.

The process_quantitity  method looks like a good
candidate for something to be in the
superclass.
    @rwest @sevyharris
    rwest authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    a0cda57 View commit details
    Browse the repository at this point in the history

  12. Tweak docstrings

    @rwest @sevyharris
    rwest authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f87edef View commit details
    Browse the repository at this point in the history

  13. Putting uncertainties on a pressure 

    for testing purposes
    @rwest @sevyharris
    rwest authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    1902bfe View commit details
    Browse the repository at this point in the history

  14. Hopefully, a way to read data from CSV files

    @rwest @sevyharris
    rwest authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    78a41a7 View commit details
    Browse the repository at this point in the history

  15. ChemKED class now successfully readstemperature column from jsr yaml

    @sevyharris
    Sai Krishna authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    97879a9 View commit details
    Browse the repository at this point in the history

  16. updated ChemKED class to read inlet and outlet compositions

    @sevyharris
    Sai Krishna authored and sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    4231b2d View commit details
    Browse the repository at this point in the history

  17. fix PEP8 and indenting

    @sevyharris
    sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    ddc8cd5 View commit details
    Browse the repository at this point in the history

  18. set SpeciesProfileDataPoint to a single reaction setting

    @sevyharris
    sevyharris committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    65da379 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. process one row at a time instead of the whole column for every datap… 

    …oint
    @sevyharris
    sevyharris committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    09bd13a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. updated class docstrings

    @sevyharris
    sevyharris committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    a523973 View commit details
    Browse the repository at this point in the history

  2. added JSR to changelog

    @sevyharris
    sevyharris committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    463bb41 View commit details
    Browse the repository at this point in the history

  3. updated old tests so they pass again

    @sevyharris
    sevyharris committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    b6da445 View commit details
    Browse the repository at this point in the history