lowram implementation #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
approved these changes
Oct 16, 2024
| * - size_t *mlen: pointer to output length of message | ||
| * - const uint8_t *sm: pointer to signed message | ||
| * - size_t smlen: length of signed message | ||
| * - const uint8_t *ctx: pointer to context tring |
There was a problem hiding this comment.
Suggested change
| * - const uint8_t *ctx: pointer to context tring | |
| * - const uint8_t *ctx: pointer to context string |
| if(ctxlen > 255 || siglen != CRYPTO_BYTES) | ||
| return -1; | ||
|
|
||
| /* Compute CRH(h(rho, t1), msg) */ |
There was a problem hiding this comment.
Suggested change
| /* Compute CRH(h(rho, t1), msg) */ | |
| /* Compute mu = CRH(H(rho, t1), 0, ctxlen, ctx, msg) */ |
| #include "poly.h" | ||
| #include "polyvec.h" | ||
|
|
||
| #define SMALL_POLY_16_BIT |
There was a problem hiding this comment.
Suggested change
| #define SMALL_POLY_16_BIT |
Comment on lines
+47
to
+54
| #ifdef SMALL_POLY_16_BIT | ||
| int j; | ||
| // buffer is the same, so we neeed to be careful | ||
| for (j = N - 1; j >= 0; j--) | ||
| { | ||
| r->coeffs[j] = tmp->coeffs[j]; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #ifdef SMALL_POLY_16_BIT | |
| int j; | |
| // buffer is the same, so we neeed to be careful | |
| for (j = N - 1; j >= 0; j--) | |
| { | |
| r->coeffs[j] = tmp->coeffs[j]; | |
| } | |
| #endif | |
| int j; | |
| // buffer is the same, so we neeed to be careful | |
| for (j = N - 1; j >= 0; j--) | |
| { | |
| r->coeffs[j] = tmp->coeffs[j]; | |
| } |
|
|
||
| /* Code to generate zetas and zetas_inv used in the number-theoretic transform: | ||
|
|
||
| #define KYBER_ROOT_OF_UNITY 17 |
There was a problem hiding this comment.
Suggested change
| #define KYBER_ROOT_OF_UNITY 17 | |
| #define KYBER_ROOT_OF_UNITY 17 | |
| #define KYBER_Q 3329 | |
| #define MONT -1044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a third implementation variant called
lowram. It focuses on using very little memory at a performance tradeoff. The implementation is written in C and based on the code in pqm4, which was added in this PR.The original ideas for this implementation are taken from the paper
and parts of the implementation in this PR are written by @mkannwischer.
I tried to retain as many files as possible from the
refimplementation by moving most memory-optimization related code tolowram.c. Further,smallntt_3329.candsmallpoly.ccontain functions to operate on polynomials with 16-bit coefficients.api.h,config.h,Makefile, andsign.care the only files that should be different fromref-- everything else is just symlinks.If there's anything that could be done to improve the quality of the implementation, feel free to let me know!
Cheers,
Amin