Add support for creating, joining, and parting osu!web rooms via interop #265
Conversation
Mostly a copy-paste from https://github.com/ppy/osu-server-beatmap-submission/blob/82190f3130bae07747fe03a2eadf8cafa81fe401/osu.Server.BeatmapSubmission/Services/LegacyIO.cs, but supports string responses.
Avoid serialising raw details about the exception (e.g. URL) and unwrap
`{ "error": "" }` JSON responses, for instance as returned by the room
creation endpoint.
Client receives:
- `APP_DEBUG=true` -> "422: Unprocessable Entity" (HTTP status code msg)
- `APP_DEBUG=false` -> "beatmaps not found: ..." (osu!web API error msg)
There was a problem hiding this comment.
The base implementation here was pulled from osu-server-beatmap-submission with local adjustments for this server's usage (return value and HubException handling).
| await leaveRoom(state, true); | ||
| await base.CleanUpState(state); | ||
| await leaveRoom(state, true); |
There was a problem hiding this comment.
Meaningless change because the base implementation is empty. I just thought I'd make this consistent with other implementations, seeing as leaveRoom can throw an exception.
| await runLegacyIO(HttpMethod.Delete, $"multiplayer/rooms/{roomId}/users/{userId}"); | ||
| } | ||
|
|
||
| private class CreateRoomRequest : Room |
There was a problem hiding this comment.
mild teeth pain from this inheritance but I guess anything else would probably be more annoying...
i guess this can stay for now maybe but as soon as this is touched for any reason we should probably decouple from Room ASAP
Co-authored-by: Berkan Diler <[email protected]>
|
Something is going to need to happen to fix the test failures here. Easiest suggestion would be to not have a static ctor in |
This server needs the ability to manage rooms for matchmaking. Because I intend to use the existing
MultiplayerHubfor matchmaking messages, I took a bit of a detour and made it the single endpoint for creating multiplayer rooms so that the client will no longer need to juggle two endpoints for doing certain things.I see a future where we move playlists, daily challenge, and even the lounge to this server, but I'm taking small meaningful steps because matchmaking is the goal for now.