-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ugly installer splash screen #173
Conversation
Moved the file into osu-deploy. Not sure if we want it in an I'm still yet to test these changes, so I'll keep this PR as a draft until I do. |
It seems velopack doesn't handle high dpi displays correctly for the splash icon. |
idk if i can place ideas out here, like in previous now closed pr, but if i can, i suggest to show some kind of artwork or something |
That's what I was hoping for. Just need to decide on the artwork. |
https://github.com/ppy/osu-resources/blob/26ac37d6d5bde86f85d2cca18cacbef6e30c8156/osu.Game.Resources/Textures/Backgrounds/registration.jpg |
Related: ppy/osu#29773
Turns out that Velopack doesn't support transparent .png's as the splashicon, leading to issues like this on installation:
Velopack supports a:
This PR reuses https://github.com/ppy/osu/blob/master/osu.iOS/Assets.xcassets/AppIcon.appiconset/300076680-5cbe0121-ed68-414f-9ddc-dd993ac97e62.png for the icon. Though, alternative designs are welcome.
Preview:
You can use this release to test it (you must not have lazer installed first)
Testing Checklist
Works as expected for me!