Update version number in config files to match the installed version #3
Conversation
Puppet is reverting this to 10.5.0.200 on every run and restarting each service. Then the software is changing this to the installed version when it when it starts each service. This will make the version match the installed version.
Match only exists in Puppet 4 so we need to use regsubst for backwards compatability.
json_pure >= 2.0.2 doesn't work on Ruby < 2 Also fix syntax error in licence_server class
|
It seems that the config files get overwritten if the config version at the top of each file is older than the installed version. |
Puppet wasn't matching on [0-9]+ but does with \d+
|
lgtm |
| @@ -8,7 +8,8 @@ group :test do | |||
| gem "puppet-syntax", :require => false | |||
| gem 'metadata-json-lint', :require => false | |||
| gem 'simplecov', :require => false | |||
| gem 'json', :require => false | |||
| gem 'json', '1.8.3', :require => false | |||
There was a problem hiding this comment.
Why are we locking to specific version here?
There was a problem hiding this comment.
json and json_pure 2.x don't work with ruby 1.9.3
1.8.3 is the last release before 2.0
| @@ -12,6 +12,7 @@ | |||
| { | |||
|
|
|||
| $version = $lumenvox::options['media_server']['version'] | |||
| $sem_ver = regsubst($version, '^(\d+\.\d+\.\d+)(.*)$','\1') | |||
There was a problem hiding this comment.
Are we sure this is sem_ver? Perhaps this is better called $version to make its meaning clear
There was a problem hiding this comment.
The $version variable get's used for installing the package and has extra characters in it that I strip out.
I thought $sem_ver was the best name because it is the version of the release.
There was a problem hiding this comment.
Cool, then how about lumenvox_version?
There was a problem hiding this comment.
That is much better. :)
Puppet is reverting this to 10.5.0.200 on every run and restarting each service.
Then the software is changing this to the installed version
when it when it starts each service.
This will make the version match the installed version.