Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1618] Font Awesome Setup Documentation - Phase 1 #3865

Merged
merged 14 commits into from
Nov 1, 2024
Merged

[PLAY-1618] Font Awesome Setup Documentation - Phase 1 #3865

merged 14 commits into from
Nov 1, 2024
+74 −1

Conversation

kangaree
Copy link
Contributor

@kangaree kangaree commented Oct 30, 2024 •
edited
Loading

What does this PR do?
Add Font Awesome setup docs for Ruby on Rails asset pipeline.

PLAY-1618

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-10-31 at 8 12 12 AM

How to test? Steps to confirm the desired behavior:

  1. Go to /guides/getting_started
  2. Click Font Awesome
  3. Review the doc

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 30, 2024
@kangaree kangaree requested review from a team as code owners October 30, 2024 19:28
@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 31, 2024
@kangaree kangaree added the Product Approved pending technical review, OK to merge to master label Oct 31, 2024
nidaqg
nidaqg previously approved these changes Oct 31, 2024
View reviewed changes
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Oct 31, 2024
@kangaree
Copy link
Contributor Author

I merged some of Mark's work from PLAY-1571 as he refactored how we sort our docs in global_variables.rb.

@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 31, 2024
@kangaree
Copy link
Contributor Author

@nidaqg , could I get another approval? I wanted to get ahead of a merge conflict in global_variables.rb

@jasperfurniss jasperfurniss added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit 3b17776 Nov 1, 2024
4 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1618-font-awesome-setup-docs-phase-1 branch November 1, 2024 18:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

You merged this pr to master branch:
- Ruby Gem: 14.7.0.pre.rc.9
- NPM: 14.7.0-rc.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdoeswork markdoeswork markdoeswork left review comments

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg left review comments

Assignees
No one assigned
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangaree @jasperfurniss @markdoeswork @nidaqg