Skip to content

Commit

Permalink
Merge pull request TheWaveWarden#447 from narenratan/patch-1
Browse files Browse the repository at this point in the history
Fix typos in tooltips and manual
  • Loading branch information
TheWaveWarden authored Jan 29, 2023
2 parents 89aa4a0 + 2b79d66 commit 3f14425
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 22 deletions.
4 changes: 2 additions & 2 deletions Source/gui/OscComponent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ OscComponent::OscComponent(OdinAudioProcessor &p_processor,
m_hp.setTextBoxStyle(Slider::NoTextBox, false, 0, 0);
m_hp.setTextValueSuffix(" Hz");
m_hp.setNumDecimalPlacesToDisplay(0);
m_hp.setKnobTooltip("The frequency of\nthe highspass filter which\nis applied to the noise");
m_hp.setKnobTooltip("The frequency of\nthe highpass filter which\nis applied to the noise");
addChildComponent(m_hp);

m_position.setSliderStyle(Slider::RotaryVerticalDrag);
Expand Down Expand Up @@ -670,7 +670,7 @@ OscComponent::OscComponent(OdinAudioProcessor &p_processor,
m_modulation_source.setIncrementValue(10, 1);
m_modulation_source.setDecrementValue(1, 10);
m_modulation_source.setDecrementValue(10, 1);
m_modulation_source.setTooltip("Select wich source modulates the wavetable position");
m_modulation_source.setTooltip("Select which source modulates the wavetable position");
m_modulation_source.OnValueChange = [&](int p_new_value) {
m_value_tree.state.getChildWithName("osc").setProperty(
m_modulation_source_identifier, (float)p_new_value, nullptr);
Expand Down
6 changes: 3 additions & 3 deletions Source/gui/ReverbComponent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ ReverbComponent::ReverbComponent(AudioProcessorValueTreeState &vts, bool p_is_st
m_EQ_gain.setTextBoxStyle(Slider::NoTextBox, false, 0, 0);
m_EQ_gain.setTextValueSuffix(" dB");
m_EQ_gain.setNumDecimalPlacesToDisplay(1);
m_EQ_gain.setKnobTooltip("Sets the gain of the build in equalizer");
m_EQ_gain.setKnobTooltip("Sets the gain of the built in equalizer");
addAndMakeVisible(m_EQ_gain);

m_EQ_freq.setSliderStyle(Slider::RotaryVerticalDrag);
m_EQ_freq.setTextValueSuffix(" Hz");
m_EQ_freq.setTextBoxStyle(Slider::NoTextBox, false, 0, 0);
m_EQ_freq.setKnobTooltip("Sets the frequency of the build in eqalizer");
m_EQ_freq.setKnobTooltip("Sets the frequency of the built in equalizer");
addAndMakeVisible(m_EQ_freq);

//m_ducking.setSliderStyle(Slider::RotaryVerticalDrag);
Expand Down Expand Up @@ -191,4 +191,4 @@ void ReverbComponent::setGUISmall() {
m_dry_wet.setBounds((REVERB_WET_POS_X) + 1, (REVERB_WET_POS_Y), (BLACK_KNOB_BIG_SIZE_X), (BLACK_KNOB_BIG_SIZE_Y));

forceValueTreeOntoComponents(m_value_tree.state);
}
}
4 changes: 2 additions & 2 deletions manual/Arpeggiator.tex
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ \chapter{Arpeggiator \& Step Sequencer}
\includegraphics[width=\textwidth]{graphics/arpeggiator.png}
\end{center}

The Arpeggiator \& Step Sequencer is a tool which is able to automatically play complex rhytmic sequences from a given set of input notes. Activating this module overrides the notes you're inputting into the synthesizer and generates note sequences itself.
The Arpeggiator \& Step Sequencer is a tool which is able to automatically play complex rhythmic sequences from a given set of input notes. Activating this module overrides the notes you're inputting into the synthesizer and generates note sequences itself.

\begin{tcolorbox}[colback=yellow!10!white,
colframe=white!20!black,
Expand Down Expand Up @@ -174,4 +174,4 @@ \chapter{Arpeggiator \& Step Sequencer}

\vspace{3mm}
Make sure the button to the left of the second row is set to "Transp" and not "Mod" to access these parameters.
}
}
10 changes: 5 additions & 5 deletions manual/FX.tex
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ \section{Delay}
\includegraphics[width=0.5\textwidth]{graphics/delay.png}
\end{center}

A delay is a module capable of producing an 'echo' effect: The signal is fed into a delay-line, which outputs the signal again after a set amount of time again. The output of the delay line can also be fed back in, allowing a chain of attenuating echos. By controlling the delay time and feeback parameters, a wide variety of effects can be achieved. The Delay module in Odin 2 goes a step further and offers several additional features.
A delay is a module capable of producing an 'echo' effect: The signal is fed into a delay-line, which outputs the signal again after a set amount of time again. The output of the delay line can also be fed back in, allowing a chain of attenuating echos. By controlling the delay time and feedback parameters, a wide variety of effects can be achieved. The Delay module in Odin 2 goes a step further and offers several additional features.

\audioparameter{Delay Time}{1}{1}{
Controls the time the delay line takes to output the sound again. Depending on the parameter "Delay Sync", this is either a dial for continuous values in Hz, or a custom selector to sync the time to the beat. This selector allows for arbitrary fractions of the current host BPM, for example 5/16th notes:
Expand Down Expand Up @@ -77,7 +77,7 @@ \section{Chorus}
\includegraphics[width=0.5\textwidth]{graphics/chorus.png}
\end{center}

The Chorus module is a delay based effect capable of thickening sounds. The generated sound resembles that of a slightly detuned ensemble, hence the name chorus. Internally, the Chorus module uses a delay line, which is read from at two diferent positions. The delay times are modulated by an internal Low Frequency Oscillator (LFO). This slightly detunes the result resulting in the Chorus sound. The LFOs for the left and right channel are phase-offset by 90$^{\circ}$ to spread the sound in the stereo field.
The Chorus module is a delay based effect capable of thickening sounds. The generated sound resembles that of a slightly detuned ensemble, hence the name chorus. Internally, the Chorus module uses a delay line, which is read from at two different positions. The delay times are modulated by an internal Low Frequency Oscillator (LFO). This slightly detunes the result resulting in the Chorus sound. The LFOs for the left and right channel are phase-offset by 90$^{\circ}$ to spread the sound in the stereo field.

\audioparameter{Chorus Rate}{1}{1}{
Controls the speed of the internal LFO. Depending on the parameter "Chorus Sync", this is either a dial for continuous values in Hz, or a custom selector to sync the time to the beat. This selector allows for arbitrary fractions of the current host BPM, for example 5/16th notes:
Expand Down Expand Up @@ -107,7 +107,7 @@ \section{Phaser}
\begin{center}
\includegraphics[width=0.5\textwidth]{graphics/phaser.png}
\end{center}
The phaser module introduces movement to the sound by applying a subtle "windy" character. The internal structure consists of a series of allpass filters: These filters do not alter the amplitude like the filters from Chapter \ref{filters}, but only shifts the phase of some frequencies. By adding the phase-shifted signal back onto the original signal, some of the frequencies get boosted, attenuated or eliminated entirely via phase-cancellation. The characteristic of the allpass-filters is continuously modulated by an internal Low Frequency Oscillator (LFO), which makes for the movemnet in the sound. The LFOs for the left and right channel are phase-offset by 90$^{\circ}$ to spread the sound in the stereo field.
The phaser module introduces movement to the sound by applying a subtle "windy" character. The internal structure consists of a series of allpass filters: These filters do not alter the amplitude like the filters from Chapter \ref{filters}, but only shifts the phase of some frequencies. By adding the phase-shifted signal back onto the original signal, some of the frequencies get boosted, attenuated or eliminated entirely via phase-cancellation. The characteristic of the allpass-filters is continuously modulated by an internal Low Frequency Oscillator (LFO), which makes for the movement in the sound. The LFOs for the left and right channel are phase-offset by 90$^{\circ}$ to spread the sound in the stereo field.

\audioparameter{Phaser Rate}{1}{1}{
Controls the speed of the internal LFO. Depending on the parameter "Phaser Sync", this is either a dial for continuous values in Hz, or a custom selector to sync the time to the beat. This selector allows for arbitrary fractions of the current host BPM, for example 5/16th notes:
Expand All @@ -134,7 +134,7 @@ \section{Phaser}
}

\audioparameter{Phaser DryWet}{1}{1}{
Controls how much of the phase-shifted signal is added to the input signal, thereby controling the strength of the effect.
Controls how much of the phase-shifted signal is added to the input signal, thereby controlling the strength of the effect.
}

\section{Flanger}
Expand Down Expand Up @@ -193,4 +193,4 @@ \section{Reverb}
}
\audioparameter{DryWet}{0}{1}{
Controls the mix of unprocessed and processed sound.
}
}
2 changes: 1 addition & 1 deletion manual/GlobalSettings.tex
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ \section{Unison}
\section{Microtuning}
\label{microtuning}

Starting from version 2.3, Odin 2 supports microtuning. This feateare can be used from subtle changes, like retuning the instrument to a different base frequency to a complete remapping of the keyboard.
Starting from version 2.3, Odin 2 supports microtuning. This feature can be used from subtle changes, like retuning the instrument to a different base frequency to a complete remapping of the keyboard.
You can find the Tuning dropdown on top of the GUI:

\begin{center}
Expand Down
2 changes: 1 addition & 1 deletion manual/Introduction.tex
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ \section{Odin 2: A Mighty God}
Don't let anybody tell you otherwise.

\vspace{1mm}
The design approach of Odin 2 lets you choose from a large variety of modules, which can be mixed and matched for virtually endless sonic capabilities. Three Oscillators, three Filters, a dedicated Distortion, four onboard FX, four Envelopes, four LFOs ... the list continues: Modulate tons of parameters with the big-ass Modulation Matrix, use the Arpeggiator and Step Sequencer to generate rhythms and musical ideas, theres Unison, a XY-Pad, you can draw your oscillator waves, or maybe your spectra?
The design approach of Odin 2 lets you choose from a large variety of modules, which can be mixed and matched for virtually endless sonic capabilities. Three Oscillators, three Filters, a dedicated Distortion, four onboard FX, four Envelopes, four LFOs ... the list continues: Modulate tons of parameters with the big-ass Modulation Matrix, use the Arpeggiator and Step Sequencer to generate rhythms and musical ideas, there's Unison, a XY-Pad, you can draw your oscillator waves, or maybe your spectra?

\vspace{2mm}
This text is supposed to fit on one page, so I can't really talk about everything Odin 2 has to offer,
Expand Down
8 changes: 4 additions & 4 deletions manual/ModulationMatrix.tex
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ \section{Modulation Destinations}
Same as moving the control knob by a value of -1.
}
\moddest{Phaser Drywet}{M}{
Modulates the ratio of processed and unprocess signals output by the Phaser module.
Modulates the ratio of processed and unprocessed signals output by the Phaser module.
}{
Same as moving the control knob by a value of +1.
}{
Expand Down Expand Up @@ -588,7 +588,7 @@ \section{Modulation Destinations}
Same as moving the control knob by a value of -1.
}
\moddest{Chorus Drywet}{M}{
Modulates the ratio of processed and unprocess signals output by the Chorus module.
Modulates the ratio of processed and unprocessed signals output by the Chorus module.
}{
Same as moving the control knob by a value of +1.
}{
Expand Down Expand Up @@ -617,7 +617,7 @@ \section{Modulation Destinations}
Same as moving the control knob by a value of -1.
}
\moddest{Flanger Drywet}{M}{
Modulates the ratio of processed and unprocess signals output by the Flanger module.
Modulates the ratio of processed and unprocessed signals output by the Flanger module.
}{
Same as moving the control knob by a value of +1.
}{
Expand Down Expand Up @@ -669,4 +669,4 @@ \section{Modulation Destinations}
Modulates to $-\infty$dB.
}
\end{longtable}
}
}
4 changes: 2 additions & 2 deletions manual/Modulators.tex
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ \section{ADSR Envelopes}
}

\audioparameter{Sustain}{1}{1}{
The Sustain determines the level that the Evelope will fall to after the Decay section. Note that the Sustain section will be active after Decay finished for as long as the MIDI-key is not released.
The Sustain determines the level that the Envelope will fall to after the Decay section. Note that the Sustain section will be active after Decay finished for as long as the MIDI-key is not released.
}

\audioparameter{Release}{1}{1}{
Expand Down Expand Up @@ -209,4 +209,4 @@ \section{Modwheel \& Pitch Bend}
A freely assignable modulation source, which is also found on most MIDI keyboards. It is therefore a very common modulation source for expressive play.

This control will automatically track all MIDI Modwheel messages (MIDI-CC 001) send to Odin 2 and update accordingly.
}
}
4 changes: 2 additions & 2 deletions manual/Oscillators.tex
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ \section{SpecDraw Osc}
\begin{center}
\includegraphics[width=0.5\textwidth]{graphics/specdraw_osc.png}
\end{center}
The SpecDraw Osc opens the sonic capabilities with some \fat{additive synthesis}. Unlike subtractive synthesis, where you filter frequencies from harmonically rich waves, additive synthesis lets you build a sound by stacking up individual harmonics. The n-th harmonic is a sine wave which has n-times the frequency of the base note. The SpecDraw Osc lets you draw the amplitude of these sine waves. The left-most bar represents the fundamental. In the initial state, only this bar ist present, resulting in an overall sine wave osc. As you bring more overtones, the sound gets richer. Additive synthesis is capable of creating timbres which are not possible with subtractive synthesis.
The SpecDraw Osc opens the sonic capabilities with some \fat{additive synthesis}. Unlike subtractive synthesis, where you filter frequencies from harmonically rich waves, additive synthesis lets you build a sound by stacking up individual harmonics. The n-th harmonic is a sine wave which has n-times the frequency of the base note. The SpecDraw Osc lets you draw the amplitude of these sine waves. The left-most bar represents the fundamental. In the initial state, only this bar is present, resulting in an overall sine wave osc. As you bring more overtones, the sound gets richer. Additive synthesis is capable of creating timbres which are not possible with subtractive synthesis.

\begin{tcolorbox}[colback=yellow!10!white,
colframe=white!20!black,
Expand All @@ -283,4 +283,4 @@ \section{SpecDraw Osc}
width=\textwidth]

The changes you make to the waveform will have no effect until you press the apply button on the bottom-right of the oscillator. If this button is red, then there are still unapplied changes to the waveform.
\end{tcolorbox}
\end{tcolorbox}

0 comments on commit 3f14425

Please sign in to comment.