Prover functions in queue #2461
Open
+173
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
prover_functions_in_queue
branch
from
1fd3ba3 to
8cce9c8
Compare
Draft
pacheco
reviewed
Feb 7, 2025
| references_per_identity: HashMap::new(), | ||
| } | ||
| } | ||
| pub fn references(&mut self, item: &QueueItem<'a, T>) -> Vec<Variable> { |
There was a problem hiding this comment.
maybe this can return an iterator, usage seems to immediately call iter().
There was a problem hiding this comment.
I tried to make this return an iterator, but I got some errors wrt either references to &mut self or temporaries in lambda functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also adds prover functions as a third kind of "queue item". The biggest change, though, is a refactoring concerning the code that computes which variables are contained in an identity. The whole mechanism is changed to handle queue items uniformly.