Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.8 compatible #737

Closed
wants to merge 1 commit into from

Conversation

sgerrand
Copy link

💁 These changes update the existing code to make it compatible with Elixir 1.18.

@sgerrand sgerrand force-pushed the elixir-1.8-compatible branch from 26225ad to a99f9c4 Compare January 20, 2025 16:04
@sgerrand sgerrand force-pushed the elixir-1.8-compatible branch from a99f9c4 to b1df77f Compare January 20, 2025 16:06
@danschultzer
Copy link
Collaborator

Which compability issues are you resolving? v1.0.39 resolves all 1.18 issues reported.

Pow doesn't use the Elixir formatter.

@sgerrand
Copy link
Author

Pow doesn't use the Elixir formatter.

Would it be useful to document that somewhere in this project, e.g. perhaps in CONTRIBUTING.md?

@sgerrand
Copy link
Author

Which compability issues are you resolving?

Thanks for checking on that and for the additional context. I had originally encountered compilation problems with Elixir 1.8 in pow-auth/pow_assent#254 and thought that there were similar problems in Pow itself. It turned out to be that my local clone was stale so I'm happy to close this now. Sorry for the noise.

@sgerrand sgerrand closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants