Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBCKP-544: Replace macro COMP_CRC32C with wrapper function under windows #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antamel
Copy link
Contributor

@antamel antamel commented Mar 1, 2023

to avoid *pg_comp_crc32c import and influence on other extensions. Use COMP_CRC32C_COMMON for all systems.

Tags: ptrack

to avoid *pg_comp_crc32c import and  influence on other extensions.
Use COMP_CRC32C_COMMON for all systems.

Tags: ptrack
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #34 (0975051) into master (42ea77d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 0975051 differs from pull request most recent head 9f284da. Consider uploading reports for the commit 9f284da to get more accurate results

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   82.71%   82.79%   +0.08%     
==========================================
  Files           2        2              
  Lines         428      436       +8     
==========================================
+ Hits          354      361       +7     
- Misses         74       75       +1     
Impacted Files Coverage Δ
engine.c 82.21% <100.00%> (+0.17%) ⬆️
ptrack.c 83.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@funny-falcon
Copy link
Contributor

Where's patch modifications for older PostgreSQL versions?

@antamel
Copy link
Contributor Author

antamel commented Mar 2, 2023

Where's patch modifications for older PostgreSQL versions?

Move your question to PBCKP-544 in our jira, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants