-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter spoint op family to add missed operator 17 (<->) #121
Conversation
Fwiw I think you shouldn't touch --1.5.0.sql given that has been released, even when it was just a pre-release. (I would suggest labeling pre-releases as beta or RC, then the question might not be as relevant.) |
@df7cb That was my unspoken question - whether to move the tag or create 1.5.1. Looking at our README I think to create 1.5.1. I will update the patch. It seems, the next release will be 1.5.1. Zeroes are unhappy :) Thank you. |
Pre-releases are not releases. I'm ok with this being part of 1.5.0, personally. |
But git tags are tags and should not be moved if people might already have seen them. I have not yet built Debian packages from that tag yet, but if I had and you moved it around afterwards, I would be quite upset. Also, if the pre-release is supposed to serve any purpose, it is for people to actually build and test it. Please don't confuse people by making another release with the same name. |
Well, Ok, but then there's no point in having pre-releases at all, and I suggest we not have them in the future. |
Just name them 1.6rc1 or the like and everything is fine. |
The upgrade script misses the altering of spoint operator family to add operator 17. It is required for k-NN search. Change the version to 1.5.1.
382a3c5
to
aaf42a8
Compare
@esabol Are you ok with these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved the PR 3 days ago, but I just saw you made another commit. Yes, it still looks good to me.
The upgrade script misses the altering of spoint operator family to add operator 17. It is required for k-NN search.