Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Trust Authentication #805

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

AndrewJackson2020
Copy link
Contributor

@AndrewJackson2020 AndrewJackson2020 commented Sep 7, 2024

This PR implements trust (no password authentication). This is somewhat related to #748 and has some overlapping changes but this PR does not require any changes to the dockerfile/CI.

This feature reflects postgres' implementation documented here.

@AndrewJackson2020
Copy link
Contributor Author

@drdrsh Any chance you can review this PR? It's tested, doesn't require any changes to the CI docker image, and has no breaking changes.

src/messages.rs Outdated Show resolved Hide resolved
tests/docker/Dockerfile Outdated Show resolved Hide resolved
@AndrewJackson2020
Copy link
Contributor Author

@drdrsh Last commit fixed the above 2 issues and cleaned up the tests a bit (implemented proper setup/teardown so a test failure doesnt leave a lingering pgcat server in the test environment, moved the trust pgcat config to a temp file generated by python so that the config is collocated with the relevant test.

@drdrsh drdrsh merged commit 670311d into postgresml:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants