Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
schloerke authored Oct 16, 2024
1 parent fb33260 commit 9d6b8fd
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions shiny/playwright/controller/_expect.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ def expect_locator_values_in_list(
The key. Defaults to `"value"`.
alt_verify
Determines if multiple expectations should be performed.
Defaults to `False`, a single (and very complicated) locator is asserting.
`True` will perform multiple assersions, which have the possibility of being invalid.
Defaults to `False`, a single (and very complicated) locator is asserted.
`True` will perform multiple assertions, which have the possibility of being invalid.
Use in playwright bug situations only.
"""
# Make sure the locator has exactly `arr` values
Expand Down Expand Up @@ -219,7 +219,7 @@ def perform_multiple_assertions():

if alt_verify:
# Accordion has issues where the single locator assertion waits forever within playwright.
# Perform multiple assertions until playwright fixes bug.
# Perform multiple assertions until playwright fixes bug.
perform_multiple_assertions()
return

Expand Down Expand Up @@ -250,6 +250,5 @@ def perform_multiple_assertions():
except AssertionError as e:
# Debug expectations
perform_multiple_assertions()

# Could not find the reason why. Raising the original error.
raise e

0 comments on commit 9d6b8fd

Please sign in to comment.