Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added more docs/examples to with_user_session_token #379

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

mconflitti-pbc
Copy link
Collaborator

Added a couple more examples to make it clearer to people using the SDK how this function works to generate a visitor client.

@mconflitti-pbc mconflitti-pbc added this to the 0.8.0 milestone Jan 27, 2025
@mconflitti-pbc mconflitti-pbc self-assigned this Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1793 1684 94% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/client.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 01033f5 by action🐍

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you!

Comment on lines +234 to +236
Example of when the visitor's token could not be retrieved (for
example, if this app allows unauthenticated access) and handle
that in cases where a token is expected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this is great, thank you

@mconflitti-pbc mconflitti-pbc merged commit e605767 into main Jan 28, 2025
35 checks passed
@mconflitti-pbc mconflitti-pbc deleted the mconflitti/add-with_user_session_token-examples branch January 28, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants