-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added more docs/examples to with_user_session_token #379
Merged
mconflitti-pbc
merged 4 commits into
main
from
mconflitti/add-with_user_session_token-examples
Jan 28, 2025
Merged
chore: added more docs/examples to with_user_session_token #379
mconflitti-pbc
merged 4 commits into
main
from
mconflitti/add-with_user_session_token-examples
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thank you!
jonkeane
reviewed
Jan 27, 2025
schloerke
reviewed
Jan 27, 2025
jonkeane
reviewed
Jan 27, 2025
jonkeane
reviewed
Jan 28, 2025
Comment on lines
+234
to
+236
Example of when the visitor's token could not be retrieved (for | ||
example, if this app allows unauthenticated access) and handle | ||
that in cases where a token is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 this is great, thank you
mconflitti-pbc
deleted the
mconflitti/add-with_user_session_token-examples
branch
January 28, 2025 19:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple more examples to make it clearer to people using the SDK how this function works to generate a visitor client.