fix: raise AttributeError instead of returning None on __getattr__ #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __getattr__ method should always raise an AttributeError if the value does not exist instead of returning None. The existing implementation causes issues when converting to a Pandas DataFrame
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
Seems simple enough! Any reason to try to capture this behavior in a test somewhere? Its generic enough that the answer might be no. |
zackverham
approved these changes
Nov 12, 2024
Eh, that code block will be gone soon enough. Probably not worth the effort at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__getattr__method should always raise anAttributeErrorif the value does not exist instead of returningNone. The existing implementation causes issues when converting to a PandasDataFrame.This error was introduced in the 0.5.0 release.