feat: add packages and content packages #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
tdstein
force-pushed
the
tdstein/304-content-packages
branch
3 times, most recently
from
d4bba40
to
1641926
Compare
|
@mmarchetti - here is a basic implementation of the '/v1/content/.../packages' endpoint. |
tdstein
force-pushed
the
tdstein/304-content-packages
branch
from
1641926
to
bedfb7d
Compare
mmarchetti
approved these changes
Nov 7, 2024
tdstein
force-pushed
the
tdstein/304-content-packages
branch
4 times, most recently
from
44e3bbc
to
9adc52d
Compare
tdstein
commented
Nov 8, 2024
| @@ -269,6 +270,11 @@ def oauth(self) -> OAuth: | |||
| """ | |||
| return OAuth(self.resource_params, self.cfg.api_key) | |||
|
|
|||
| @property | |||
| @requires(version="2024.10.0-dev") | |||
There was a problem hiding this comment.
I will bump this to 2024.11.0 after the release.
tdstein
commented
Nov 8, 2024
tdstein
commented
Nov 8, 2024
tdstein
commented
Nov 8, 2024
tdstein
changed the title
tdstein
force-pushed
the
tdstein/304-content-packages
branch
from
9adc52d
to
3eadab8
Compare
The __getattr__ method should always raise an AttributeError if the value does not exist instead of returning None. The existing implementation causes issues when converting to a Pandas DataFrame
tdstein
force-pushed
the
tdstein/304-content-packages
branch
from
3eadab8
to
2af9e39
Compare
|
I'll fix those linting errors. |
mmarchetti
reviewed
Nov 12, 2024
schloerke
requested changes
Nov 12, 2024
src/posit/connect/packages.py
Outdated
| hash: NotRequired[Optional[str]] | ||
| """Package description hash for R packages.""" | ||
|
|
||
| @overload |
There was a problem hiding this comment.
Suggested change
| @overload |
src/posit/connect/packages.py
Outdated
Comment on lines
89
to
93
|
|
||
| @overload | ||
| def find_by(self, **conditions): ... | ||
|
|
||
| def find_by(self, **conditions): |
There was a problem hiding this comment.
No need for the overload and don't lose typing support when something is misspelled or a wrong type is given
Suggested change
| @overload | |
| def find_by(self, **conditions): ... | |
| def find_by(self, **conditions): |
There was a problem hiding this comment.
I'm seeing...
Method "fetch" overrides class "ActiveSequence" in an incompatible manner
Parameter "**conditions" has no corresponding parameterPylance[reportIncompatibleMethodOverride](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportIncompatibleMethodOverride)
I'm looking for a workaround, but no luck so far.
src/posit/connect/packages.py
Outdated
| version: Required[str] | ||
| """The package version""" | ||
|
|
||
| @overload |
There was a problem hiding this comment.
Same as above
Suggested change
| @overload |
src/posit/connect/packages.py
Outdated
Comment on lines
156
to
161
| def fetch(self, **conditions: Unpack[_Fetch]): ... | ||
|
|
||
| @overload | ||
| def fetch(self, **conditions): ... | ||
|
|
||
| def fetch(self, **conditions) -> Generator["Package"]: |
There was a problem hiding this comment.
Suggested change
| def fetch(self, **conditions: Unpack[_Fetch]): ... | |
| @overload | |
| def fetch(self, **conditions): ... | |
| def fetch(self, **conditions) -> Generator["Package"]: | |
| def fetch(self, **conditions: Unpack[_Fetch]) -> Generator["Package"]: |
src/posit/connect/packages.py
Outdated
| app_guid: NotRequired[str] | ||
| """The unique identifier of the application this package is associated with""" | ||
|
|
||
| @overload |
There was a problem hiding this comment.
Suggested change
| @overload |
src/posit/connect/packages.py
Outdated
Comment on lines
226
to
230
|
|
||
| @overload | ||
| def find_by(self, **conditions) -> "Package | None": ... | ||
|
|
||
| def find_by(self, **conditions) -> "Package | None": |
There was a problem hiding this comment.
Same as above
Suggested change
| @overload | |
| def find_by(self, **conditions) -> "Package | None": ... | |
| def find_by(self, **conditions) -> "Package | None": |
schloerke
approved these changes
Nov 12, 2024
toph-allen
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds packages support.
Resolves #304
Requires https://github.com/rstudio/connect/issues/28227