Be defensive about global aux channel being dropped #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
LGTM, and fixed the crash in my testing. With my own local changes to fix reconnect on workbench, this crash becomes 100% reproducible, so I'm going to merge this around and bump versions so we can consider it for Workbench. Thanks so much for jumping on this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #617
Addresses posit-dev/positron#5321
This will still cause weirdness as duplicate LSP sessions will keep using that global channel to communicate log messages and diagnostics, and these will end up being published by the newer LSP session.
To fix this we could take this opportunity to move from tower-lsp to lsp-server. The former has been unmaintained for a while and has multiple issues that require workarounds. The latter would give us much more control over the LSP event loop and allow us to initiate a session shutdown from the server to prevent duplicate LSP sessions.