-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package information in completions #616
Conversation
I think we also need to let the client know we support this Look for It's possible we could be working with a client that doesn't support this, but it is >3 years old now so its probably ok to ignore the client supplied option for now (we should still set the server side one though) |
let detail = format!("({})", parameters.joined(", ")); | ||
let label_details = item_details(Some(detail), package); | ||
item.label_details = Some(label_details); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we have many ways to see the function parameters, and by far the most useless one is seeing the function parameters in this completion item menu - the parameters are very scrunched together and you can't see their defaults and they are often cut off. Plus, the point of this menu is to pick the function, not supply the arguments, that comes later
I vote for just showing the package name, and doing a little work to strip out parameters
here all together, since its probably a non trivial amount of work to compute it and we won't need it anymore.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
b4b1fc8
to
984b5ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this feels great, love the ::
Addresses posit-dev/positron#5225
Positron Release Notes
New Features
::
suffix to make it clearer what is being completed.Bug Fixes