Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing upgrade params only if the env is set. #80

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Passing upgrade params only if the env is set. #80

merged 1 commit into from
Dec 3, 2017

Conversation

piyush-nimbalkar
Copy link
Contributor

  • Allowing focus param, to selectively run tests

adityadani
adityadani requested changes Dec 2, 2017
View reviewed changes
Copy link
Member

@adityadani adityadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the docs(OR create an issue) with these new params?

deployments/deploy-aws.sh Outdated
fi

if [ -n "${STORAGE_BASE_VERSION}" ]; then
UPGRADE_ARGS="--storage-drvier-base-version=$STORAGE_BASE_VERSION $UPGRADE_ARGS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--storage-driver-base-version

deployments/deploy-ssh.sh Outdated
fi

if [ -n "${STORAGE_BASE_VERSION}" ]; then
UPGRADE_ARGS="--storage-drvier-base-version=$STORAGE_BASE_VERSION $UPGRADE_ARGS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--storage-driver-base-version

Passing upgrade params only if the env is set.
59fb273 
- Allowing focus param, to selectively run tests
@piyush-nimbalkar
Copy link
Contributor Author

Created issue to track the documentation: #81

@piyush-nimbalkar
Copy link
Contributor Author

Verified this in jenkins. Merging in master

@piyush-nimbalkar piyush-nimbalkar merged commit ee0cfee into portworx:master Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityadani adityadani adityadani approved these changes

@harsh-px harsh-px Awaiting requested review from harsh-px

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyush-nimbalkar @adityadani