-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving process #8
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 24 26 +2
Lines 3179 3308 +129
=======================================
- Misses 3179 3308 +129
Continue to review full report at Codecov.
|
To add Zarr and TIFF backends, I think it would make sense to add an extra (abstract) class: DataDestination, which would have a |
Make sense, and planar lightsheet should definitively be just a 1z-slice volume. |
@vilim following the current flow of the code, the saver should be initialised agnostic to xy plane size and then inferred it from the first stack. I think it would be cleaner to calculate them continuously with the (unsaved) frames that are streamed to the |
Well, the thing is that if the experiments gets manually stopped beforehand, you still want to save a vaild dataset, so the full dimensions cannot be know beforehand. I think it's fine that the DataDestination initializes the temporary storage (so the saver doesn't do that at all) |
So in principle the full size should be known beforehand and "preallocated" (in the SplitDs attributes), but then the case of interruption should be handled? |
This is one variant, the other is just to be agnostic to it. I don't care which it is as long as it works in all cases. |
Note: I have added a notifier interface to master, so this needs to be changed a bit. (maybe adding Diego's picture-sending functionality from the 2p, and then making 2p rely on this, but that would be a separate PR). |
Moving here code for the saving process from sashimi, and adding testing and cleanup in the process.
Changes so far: