Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of state #13

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Fix implementation of state #13

merged 3 commits into from
Dec 1, 2023

Conversation

stephank
Copy link
Member

@stephank stephank commented Dec 1, 2023

I goof'd. State is a callback query param, not a token claim.

@stephank
Revert "Update README example"
4f89b67 
This reverts commit 428adca.
@stephank
Revert "Add support for state parameter"
d731cd5 
This reverts commit b32a75b.
@stephank
Add support for state parameter (take two)
5b1e389 
The previous implementation incorrectly took state from the token
claims, but it is returned as a normal query parameter to the callback,
so outside the scope of client libraries.
@stephank stephank merged commit 7893131 into main Dec 1, 2023
1 check passed
@stephank stephank deleted the feat/state branch December 1, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stephank