Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absence of the consent state cookie is not handled correctly #15

Conversation

switchnollie
Copy link
Contributor

@switchnollie switchnollie commented Apr 20, 2023

Pull Request Checklist

Closes #10

@switchnollie switchnollie linked an issue Apr 20, 2023 that may be closed by this pull request
@switchnollie switchnollie requested a review from pboeder April 20, 2023 08:53
Copy link
Member

@pboeder pboeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR, @switchnollie !

I added some remarks. Also make sure, that the tests are green :)

packages/cookie-consent-banner/.eslintrc Show resolved Hide resolved
packages/cookie-consent-banner/src/utils/parseCookies.ts Outdated Show resolved Hide resolved
@pboeder pboeder changed the title 14 absence of the consent state cookie is not handled correctly fix: absence of the consent state cookie is not handled correctly Apr 24, 2023
@switchnollie switchnollie merged commit 5b5f035 into main Apr 25, 2023
@pboeder pboeder deleted the 14-absence-of-the-consent-state-cookie-is-not-handled-correctly branch April 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants