Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@feature "startChecked" new property for CategoryItem #10

Open
checamon opened this issue Jan 12, 2023 · 1 comment · Fixed by #15
Open

@feature "startChecked" new property for CategoryItem #10

checamon opened this issue Jan 12, 2023 · 1 comment · Fixed by #15

Comments

@checamon
Copy link

checamon commented Jan 12, 2023

Node/npm version(s):
8.19.2

Package(s) version(s):
3.0.1 (React)

Browser(s) version(s):
Version 1.46.153 Chromium: 108.0.5359.128 (Official Build) (64-bit)

Description of the issue/feature:
Maybe there is a way of doing this already but I haven't found it yet.

A new property for CategoryItem, startChecked.

With the purpose of allowing the developer to get all/some of the cookie categories checked and allow the users to uncheck them if they wish to. As opposed to how it behaves now.

Right now it appears to only "pre" check the mandatory categories, which is great, but it would be good to have the option to pre-check optional categories as well.

Regards

@checamon checamon changed the title #feature "startChecked" new property for CategoryItem @feature "startChecked" new property for CategoryItem Jan 12, 2023
@pboeder
Copy link
Member

pboeder commented Jan 23, 2023

Hi @checamon!

I didn't include that feature, because it's not really nice for the user to actively uncheck things he/she doesn't want.
However, it would be awesome, if you create a PR for that.

From what I see, we might need to extend the type CategoryItem with isPreselected or something. Also extend that filter function with the new attribute.

Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants