Fix input device error handling

Managed devices do not need to be explicitly unregistered or freed, as this is handled by devres. Drop the call to input_free_device. Signed-off-by: Tim Crawford <[email protected]>
pop-os · Dec 21, 2021 · a02b101 · a02b101
1 parent b49caa5
commit a02b101
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/system76_acpi.c b/system76_acpi.c
@@ -732,10 +732,8 @@ static int system76_add(struct acpi_device *acpi_dev)
 	input_set_capability(data->input, EV_KEY, KEY_SCREENLOCK);
 
 	err = input_register_device(data->input);
-	if (err) {
-		input_free_device(data->input);
-		return err;
-	}
+	if (err)
+		goto error;
 
 	err = system76_get_object(data, "NFAN", &data->nfan);
 	if (err)