Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add media_stop key #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathansgithub
Copy link

@nathansgithub nathansgithub commented Oct 3, 2021

This adds the option to set a media stop key on the Launch. Issue #100

@jackpot51 jackpot51 requested review from a team October 4, 2021 13:25
@leviport
Copy link
Member

leviport commented Oct 4, 2021

I never understood the purpose of the stop key. Do you use it regularly? If so, what for?

@nathansgithub
Copy link
Author

I never understood the purpose of the stop key. Do you use it regularly? If so, what for?

I like erring on the side of having more options than fewer options as a user, and adding a stop key doesn't need much of a change in the interface.

But I use it as a convenient way to restart a track from the beginning. Depending on the program you're using, the previous track button usually starts playing the previous track (and loads that track if it's playing over a network) by default instead of resetting the current track. So sometimes a stop key is more convenient.

@leviport
Copy link
Member

leviport commented Oct 4, 2021

I think the stop key would be a good addition to the future "advanced keycodes" section discussed here, but I do think we should avoid adding clutter on the main page until then. The stop key was skipped originally because of doubts about how widely used it would be, and I still feel that few people would end up using it.

If anyone disagrees with my assessment, please react to this comment with a 👎 so we can gauge interest in adding a stop key to the main page.

@nathansgithub
Copy link
Author

nathansgithub commented Oct 4, 2021

I think the stop key would be a good addition to the future "advanced keycodes" section discussed here, but I do think we should avoid adding clutter on the main page until then.

Thanks for the feedback. I agree that most of those keys belong on a new page or menu. I think a stop key would make sense either on the main screen or a separate one, but the first place I would expect to find it would be next to the play/pause and skip key options, and it's only one extra key. And it's pretty common to find it on media players and stereos with those keys (even if it has been getting less common).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants