Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add select flag for motion and click actions #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add select flag for motion and click actions #265

wants to merge 1 commit into from

Conversation

Riateche
Copy link
Contributor

@Riateche Riateche commented Jun 8, 2024

Added select flag to Action::Motion and Action::Click to implement hotkeys with Shift modifier (e.g. Shift + ArrowRight to create or extend the selection) and fix hotkeys without Shift (e.g. ArrowRight previously didn't clear existing selection).

Fixed Previous and Next behavior when there is a selection. They now clear selection and put the cursor to the start and end of the selection, respectively.

Implemented select flag for examples.

@Riateche Riateche mentioned this pull request Jun 8, 2024
Closed
jackpot51
jackpot51 reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to test how this works with ViEditor before approving

@Riateche
Copy link
Contributor Author

Rebased onto main. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Riateche @jackpot51