Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edit::cursor_position #262

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

Riateche
Copy link
Contributor

@Riateche Riateche commented Jun 8, 2024

Added Edit::cursor_position() method to retrieve the coordinates of the visual cursor. This is required to set the IME position, so that the input method window is displayed close to the cursor. The current implementation simply reuses the Editor::draw() code (moved out to a function). This can probably be done more efficiently.

Copy link
Member

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal API is a bit strange in my opinion, but the new Edit::cursor_position function seems fine to me.

@jackpot51 jackpot51 merged commit a3a6262 into pop-os:main Jun 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants